chore(migration): remove duplicated code when copying legacy config to new path.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #8166 from nextcloud/backport/8160/stable-3.16

[stable-3.16] fix(msi): allow custom installation directory

fix(msi): allow custom installation directory

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8162 from nextcloud/backport/8156/stable-3.16

[stable-3.16] fix(theme): correct dark/light mode check on Win10

fix(theme): correct dark/light mode check on Win10

`Utility::registryGetKeyValue` returns an invalid QVariant should the
key not exist -- which is the case if that switch has never been toggled
before.

--> Fix this by ensuring the QVariant is valid, and only then try to
convert it to a bool.

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8159 from nextcloud/backport/5543/stable-3.16

[stable-3.16] Use AccountPtr in Account signals instead of raw pointer

fix(gui): Use AccountPtr in setup wizard

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix use of saveAccount in networksettings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in testpushnotifications

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in serverVersionChanged signal instead of raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Replace use of raw pointer in wantsAccountSaved signal with AccountPtr

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Emit AccountPtr from pushNotificationsDisabled in Account rather than raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use AccountPtr in pushNotificationsReady signal in Account rather than raw pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8158 from nextcloud/backport/5288/stable-3.16

[stable-3.16] Exclude NavigationPaneHelper from non-Windows compile

Only build NavigationPaneHelper on Windows

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ifdef all mentions of navigationpanehelper out of non-Windows builds

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8163 from nextcloud/backport/8038/stable-3.16

[stable-3.16] skip single test or whole test file for macOS: they are broken

skip single test or whole test file for macOS: they are broken

would need careful analyze to fix those

until we can get them fixed, better make the other tests be required in
the CI

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8157 from nextcloud/backport/8111/stable-3.16

[stable-3.16] fix(PinState): don't trigger sync when file's PinState changed to Unspecified.

test(cfapi): check for spurious attribute changes.

Signed-off-by: Camila Ayres <hello@camilasan.com>

fix(PinState): don't trigger sync when file's PinState changed to Unspecified.

LibreOffice/Microsoft office might touch the files for unknown reasons,
creating a constant sync state (icon) visible in the parent folder.

This fix excludes PinState changes from a new sync if the trigger
might have been an external application.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8153 from nextcloud/backport/8145/stable-3.16

[stable-3.16] simplify deletions of invalid read-only items: do not interrupt sync

fix: do not interrupt sync when cleaning invalid read-only items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8141 from nextcloud/backport/8140/stable-3.16

[stable-3.16] disable use of bulk upload for small files

disable use of bulk upload for small files

this feature causes many issues with impact on users so we prefer to
disable it again

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8139 from nextcloud/backport/8048/stable-3.16

[stable-3.16] Bugfix/slow bulk upload

simple way to add more logs related to upload progress

will be important to try to see upload performance bottlenecks

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

clean up some no longer needed logs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

better logs to track sending of data during bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

clean code and logs during bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

no need to disable buffering from Qt in POST requests

data of the files are ready in a memory buffer so Qt will not buffer
them anyway

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use maximum chunk size to decide the size of a bulk upload request

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

remove useless log

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

define content length header with bulk upload requests

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

use memory to buffer the data of the files sent during bulk upload

should help make it faster to send all data

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

disable buffering when POSTing for bulk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Add test for syncing with bulk upload when there are errors.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Change bulk upload batch size when there is a sync error.

- Cancel sync after try with smaller bulk upload batch size also throws error.
- Continue syncing when there is no error.
- Remove file from bulk upload black list only when upload succeeded.

Signed-off-by: Camila <hello@camila.codes>

Merge pull request #8137 from nextcloud/backport/8094/stable-3.16

[stable-3.16] Bugfix/use newer bulk upload checksum header

only send the md5 custom checksum header when server expects it

server before 32.0.0 release expects a custom header with an MD5
checksum during bulk upload

the header name is: X-File-MD5

see https://github.com/nextcloud/server/pull/51729

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

with release 32.0.0 md5 custom checksum is removed from bulkupload

makes our fake server require an md5 custom checksum for bulk upload
until version 32.0.0

starting with 32.0.0 this custom checksum must be empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

fix format of checksum header that was missing checksum type

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

sending header X-File-MD5 that is currently mandatory

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

automated tests of bulk upload needs to check checksums like real

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8131 from nextcloud/backport/8095/stable-3.16

[stable-3.16] fix: try to correct mtime on upsyncs

fix FileSystem::setModTime on x64 Windows with times > 2038

also removes some unused Utility methods

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

fix: try to correct mtime on upsyncs

Files with a modification time of less than 0 do usually not make sense
(and afaik the server doesn't accept them either).
--> attempt to update the modification time to _Time.now_ while
propagating

side note: I ran into this because KArchive/Ark(?) didn't consider the
extra time attributes on entries for a certain zip file, so it instead
used the standard time value of each zip entry which was set to <= 1980
for files and < 1970 for directories...

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8130 from nextcloud/backport/8127/stable-3.16

[stable-3.16] stop using QFile api to delete a single local file

stop using QFile api to delete a single local file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8129 from nextcloud/backport/8128/stable-3.16

[stable-3.16] remove bogus check that tried to check for existing case clash conflict

remove bogus check that tried to check for existing case clash conflict

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8126 from nextcloud/backport/8121/stable-3.16

[stable-3.16] fix: move array to correct value in dict

fix: move array to correct value in dict

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8125 from nextcloud/backport/8122/stable-3.16

[stable-3.16] fix crash within FolderStatusModelTest

fix crash within FolderStatusModelTest

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8123 from nextcloud/backport/8118/stable-3.16

[stable-3.16] remove costly availability check that is never used

remove costly availability check that is never used

we never read the value computed

computing it means a recursive visit of the whole folder hierarchy which
could be taking a long time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #8124 from nextcloud/backport/8120/stable-3.16

[stable-3.16] Bugfix/delete errors

better error message for user when deleting local items

we might be displaying too technical errors that the user will have no
way to understand

for example on macOS, we might be getting:
Unknown error: 513

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

when deleting a folder starts by making it read-write permissions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

we must not use QFile::remove that may fail on windows read-only files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

if we are going to need modified permissions: always change

we might need to change the permissions, so do it instead of trying to
be smart

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

do not change permissions of invalid items on discovery

if we are going to delete those items, we will make them have the proper
permissions when we need

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

always make the file we try to delete be read-write as required

on windows you must only delete read-write files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Qt 6.8 requires macSO 12 or higher: no need to compile against older

clean up preprocessor directives for older macOS releases that are not
supported by macOS minimum required release from the Qt 6.8 release we
require

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8117 from nextcloud/backport/8107/stable-3.16

[stable-3.16] fix(mac-crafter): Work around broken consecutive shell integration builds

fix(mac-crafter): Work around broken consecutive shell integration builds

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #8116 from nextcloud/backport/8109/stable-3.16

[stable-3.16] fix(gui): remove ignored file notifications from Activity list

fix(gui): remove ignored file notifications from Activity list

These are informative notifications without any need/possibility to act
on immediately -- if a file is not synced it will be visible from the
shell integration anyway.

An eventual follow-up to this change would be to have a dialogue with an
overview of all files that were ignored (including the entry in the
ignore list that caused a specific file to be ignored).

Closes #6712

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Merge pull request #8115 from nextcloud/backport/8114/stable-3.16

[stable-3.16] fix(mac): bump deployment target to 12.0

fix(mac): bump deployment target to 12.0

Qt 6.8 now requires macOS 12.0 as per https://doc.qt.io/qt-6.8/macos.html

for comparison, Qt 6.7 supported 11.0 and newer: https://doc.qt.io/qt-6.7/macos.html

also update the Packages project to refuse to install on anything older
than Monterey (12.0)

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #8089 from nextcloud/backport/8080/stable-3.16

[stable-3.16] gui/macOS: Fix memory issues in Objective-C++ code for FileProvider support

gui/macOS: Properly retain/release NSFileProviderManager(s)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid need to retain/release things in file provider edit locally

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid crash from bad manager release

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Avoid retain call on extensionNcAccount by allocing new string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Improve overall memory management in XPCUtils::getDomainManagers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Do not leak debug log string after use

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Use explicit type in connections array arg

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Correctly release objects received via FileProviderUtils functions

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Properly wait for eviction result in materialised items model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

gui/macOS: Do not leak local url and error objects in edit locally job

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>